Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional OIDC claims #996

Closed
JordanSussman opened this issue Aug 19, 2024 · 0 comments · Fixed by go-vela/server#1172
Closed

Additional OIDC claims #996

JordanSussman opened this issue Aug 19, 2024 · 0 comments · Fixed by go-vela/server#1172
Labels
enhancement Indicates an improvement to a feature

Comments

@JordanSussman
Copy link
Collaborator

Description

After integrating the new OpenID Connect support with some third-party providers, it has become clear that our current claims layout is somewhat restrictive. For instance, some providers don’t support using wildcards for claim validation, making it difficult to include the tag in the image field. It would be helpful to include additional fields that can be individually validated.

Value

More easily support 3rd party providers usage of OpenID connect.

Definition of Done

I'm currently proposing the following additions to the claims:

  • Image name without tag (string)
  • Image tag without name (string)
  • Branch name (string)
  • Fork (boolean)

Effort (Optional)

1 day

Impacted Personas (Optional)

All users that utilize OpenID connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant