New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rel.Text should be NVARCHAR(MAX) #7

Closed

billgraziano opened this issue Mar 13, 2021 · 1 comment

billgraziano commented Mar 13, 2021 •

edited

Loading

Same disclaimer: Just reviewing code, not an actual user at this point.

The "text" type is deprecated in SQL Server and will be removed in a future version.

https://docs.microsoft.com/en-us/sql/t-sql/data-types/ntext-text-and-image-transact-sql?view=sql-server-ver15

Microsoft suggests replacing with NVACHAR(MAX) or VARCHAR(MAX). I'd prefer NVARCHAR(MAX) to support Unicode.

Lines 143 to 145 in e7d7d12

    
           case rel.Text: 
        
           	typ = "TEXT" 
        
           	m = column.Limit

Fs02 mentioned this issue

Use NVARCHAR for string and text type #10

Merged

Member

Fs02 commented Mar 14, 2021

Thanks for your feedback, it's very helpful 🙏
I've created a pr to address this issue, please take a look if you have time 😄

Fs02 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment