Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go 1.9 and earlier tests #353

Closed
johnweldon opened this issue Jan 4, 2022 · 4 comments
Closed

Fix Go 1.9 and earlier tests #353

johnweldon opened this issue Jan 4, 2022 · 4 comments

Comments

@johnweldon
Copy link
Member

Dependency on github.com/Azure/go-ntlmssp should either be pinned to a passing version, or we decide if we want to drop testing for pre-1.10 versions? I'd prefer the former option. ( See discussion on #352 )
@cpuschma
Copy link
Member

cpuschma commented Jan 4, 2022

Personally, I'd prefer the latter one as well. Also, since the last release of go1.10.x, multiple security patches + fixes have been applied to the std libs. For example:

@johnweldon
Copy link
Member Author

Okay, let's drop support for Go 1.9 and earlier.

@cpuschma
Copy link
Member

cpuschma commented Mar 12, 2022 •
edited
Loading

I suggest v1.13, since go-asn1-ber uses this version as well

@johnweldon Are you ok with this? If you greenlight this I'll make a PR

@johnweldon
Copy link
Member Author

I thought I'd responded to this... sorry... yes I'm okay with v1.13+

@johnweldon johnweldon mentioned this issue Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnweldon @cpuschma