Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package fwk/testdata (Go reserved name) #941

Closed
dolmen opened this issue May 4, 2022 · 2 comments · Fixed by #942
Closed

Rename package fwk/testdata (Go reserved name) #941

dolmen opened this issue May 4, 2022 · 2 comments · Fixed by #942

Comments

@dolmen
Copy link
Contributor

dolmen commented May 4, 2022

testdata is a special name for the Go toolchain. go help packages says:

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".

Package go-hep.org/x/hep/fwk/testdata should be renamed to avoid problems.

@dolmen dolmen changed the title Rename package fwk/testdata Rename package fwk/testdata (Go reserved name) May 4, 2022
@dolmen
Copy link
Contributor Author

dolmen commented May 4, 2022

This issue blocks any further changes I would like to propose to the fwk code as files in the fwk/testdata package would be affected.

@sbinet
Copy link
Member

sbinet commented May 5, 2022

yeah, the code under that testdata "fake" package was written before the "internal" concept existed.
I guess one could move that code under, say, "fwk/internal/fwktest" or something.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants