Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to audit which features of gorm require the usage of gogo/protobuf? #3301

Closed
daodennis opened this issue Aug 24, 2020 · 2 comments
Closed
Assignees
Labels

Comments

@daodennis
Copy link

Hi,

Is there way to figure out if I can use vanilla protobufs instead of gogo/protobufs? In my protos the only mention of gogo is near the top:

import "github.com/gogo/protobuf/gogoproto/gogo.proto";
option (gogoproto.goproto_registration) = true;

The only other features I am using are these:

(gorm.field) = {reference_of: "User"}];
(gorm.field).has_one = { foreignkey_tag: { primary_key: true }}];
(gorm.field).tag = { primary_key: true }];
(gorm.field).tag = { primary_key: true, type: "varchar(255)" }];
(gorm.field).tag = { type: "varchar(128)" }];
(gorm.field).tag = { type: "varchar(128)" }]; // 1 Street St
(gorm.field).tag = { type: "varchar(128)" }]; // San Francisco
(gorm.field).tag = { type: "varchar(16)" }];  // 94103
(gorm.field).tag = { type: "varchar(16)" }];  // CA
(gorm.field).tag = { type: "varchar(255)" }];
(gorm.field).tag = { type: "varchar(32)" }];
(gorm.field).tag = { type: "varchar(4096)" }];
(gorm.field).tag = { type: "varchar(512)" }];
(gorm.opts).ormable = true;

I was given this advice about a project I am working on,

That project is definitely in for a ride.  They shouldn't upgrade to the newer gogo/protobuf but move straight to use github/golang/protobuf v1.4.2 in combination with google.golang.org/protobuf for the new plugin packages.

Do I have any control over what versions of gogo/protobuf or the usage of github.com/golang/protobuf or golang.google.org/protobuf I'm using if I depend on gorm v1 in my project?

@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Aug 24, 2020
@github-actions
Copy link

This issue has been automatically marked as stale as it missing playground pull request link, checkout https://github.com/go-gorm/playground for details, it will be closed in 2 days if no further activity occurs.

@jinzhu
Copy link
Member

jinzhu commented Aug 24, 2020

GORM doesn't require gogo/protobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants