Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A hack but a bit dangerous solution to unencrypted connection #125

Open
cgyim opened this issue Sep 20, 2018 · 1 comment
Open

A hack but a bit dangerous solution to unencrypted connection #125

cgyim opened this issue Sep 20, 2018 · 1 comment

Comments

@cgyim
Copy link

cgyim commented Sep 20, 2018

I use gomail to test my routine work, but also encounter the 'unencrypted' problem, so I check both the gomail and golang SMTP source code and found a hack solution. The SMTP.Auth has only one implementation, that is, the plainAuth, so I reimplement the interface as a new type 'FakeEncryptedAuth', but the start() method in new implementation does not check the server'TLS, so it bypasses the check(and the check panic if server'TLS is false, that's why panic when I want to send email via plaintext transport). And in new implementation, We can choose if we bypass the check
my implementation : https://github.com/cgyim1992/gomail.

@pedromorgan
Copy link

see #104 and #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants