From 3634a35680d6f0bd23ee53c7cfec76d1741525dc Mon Sep 17 00:00:00 2001 From: jaqra Date: Wed, 11 Sep 2019 23:33:26 +0300 Subject: [PATCH 1/5] Move ref (branch or tag) location on issue list page --- public/css/index.css | 2 ++ public/less/_repository.less | 9 +++++++++ templates/repo/issue/list.tmpl | 8 +++++--- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/public/css/index.css b/public/css/index.css index 2cc7b42cef44f..4453107946a11 100644 --- a/public/css/index.css +++ b/public/css/index.css @@ -784,6 +784,8 @@ footer .ui.left,footer .ui.right{line-height:40px} .issue.list>.item .desc .checklist .progress-bar .progress{background-color:#ccc;display:block;height:100%} .issue.list>.item .desc a.milestone{padding-left:5px;color:#999!important} .issue.list>.item .desc a.milestone:hover{color:#000!important} +.issue.list>.item .desc a.ref{padding-left:5px;color:#999!important} +.issue.list>.item .desc a.ref:hover{color:#000!important} .issue.list>.item .desc .assignee{margin-top:-5px;margin-right:5px} .issue.list>.item .desc .overdue{color:red} .page.buttons{padding-top:15px} diff --git a/public/less/_repository.less b/public/less/_repository.less index a64763b393dc4..41518ae17b7f3 100644 --- a/public/less/_repository.less +++ b/public/less/_repository.less @@ -1993,6 +1993,15 @@ } } + a.ref { + padding-left: 5px; + color: #999999 !important; + + &:hover { + color: #000000 !important; + } + } + .assignee { margin-top: -5px; margin-right: 5px; diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index 8bdc0dfa92e8e..856ff31b3e02f 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -217,9 +217,6 @@ {{end}} {{end}} - {{if .Ref}} - {{.Ref}} - {{end}} {{range .Labels}} {{.Name}} {{end}} @@ -254,6 +251,11 @@ {{.Milestone.Name}} {{end}} + {{if .Ref}} + + {{.Ref}} + + {{end}} {{if ne .DeadlineUnix 0}} {{.DeadlineUnix.FormatShort}} From 11c2bd1fc75ace38ea466c134bcaa16a532873c9 Mon Sep 17 00:00:00 2001 From: jaqra Date: Wed, 11 Sep 2019 23:46:50 +0300 Subject: [PATCH 2/5] Make looks better --- public/css/index.css | 5 +++-- public/less/_repository.less | 8 ++++++-- templates/repo/issue/list.tmpl | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/public/css/index.css b/public/css/index.css index 4453107946a11..5339aefe67bfa 100644 --- a/public/css/index.css +++ b/public/css/index.css @@ -782,10 +782,11 @@ footer .ui.left,footer .ui.right{line-height:40px} .issue.list>.item .desc .checklist{padding-left:5px} .issue.list>.item .desc .checklist .progress-bar{margin-left:2px;width:80px;height:6px;display:inline-block;background-color:#eee;overflow:hidden;border-radius:3px;vertical-align:2px!important} .issue.list>.item .desc .checklist .progress-bar .progress{background-color:#ccc;display:block;height:100%} -.issue.list>.item .desc a.milestone{padding-left:5px;color:#999!important} +.issue.list>.item .desc a.milestone{margin-left:5px;color:#999!important} .issue.list>.item .desc a.milestone:hover{color:#000!important} -.issue.list>.item .desc a.ref{padding-left:5px;color:#999!important} +.issue.list>.item .desc a.ref{margin-left:8px;color:#999!important} .issue.list>.item .desc a.ref:hover{color:#000!important} +.issue.list>.item .desc a.ref span{margin-right:-4px} .issue.list>.item .desc .assignee{margin-top:-5px;margin-right:5px} .issue.list>.item .desc .overdue{color:red} .page.buttons{padding-top:15px} diff --git a/public/less/_repository.less b/public/less/_repository.less index 41518ae17b7f3..3ba747bdd13bf 100644 --- a/public/less/_repository.less +++ b/public/less/_repository.less @@ -1985,7 +1985,7 @@ } a.milestone { - padding-left: 5px; + margin-left: 5px; color: #999999 !important; &:hover { @@ -1994,12 +1994,16 @@ } a.ref { - padding-left: 5px; + margin-left: 8px; color: #999999 !important; &:hover { color: #000000 !important; } + + span { + margin-right: -4px; + } } .assignee { diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index 856ff31b3e02f..612b62ca8258c 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -253,7 +253,7 @@ {{end}} {{if .Ref}} - {{.Ref}} + {{.Ref}} {{end}} {{if ne .DeadlineUnix 0}} From ee63be85114b332fb933dc5a58eba989aab5875d Mon Sep 17 00:00:00 2001 From: jaqra Date: Thu, 12 Sep 2019 08:28:21 +0300 Subject: [PATCH 3/5] move branch label also on milestone/{id} page --- templates/repo/issue/milestone_issues.tmpl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/templates/repo/issue/milestone_issues.tmpl b/templates/repo/issue/milestone_issues.tmpl index 738ac4b81610c..889cd2c2f6715 100644 --- a/templates/repo/issue/milestone_issues.tmpl +++ b/templates/repo/issue/milestone_issues.tmpl @@ -187,9 +187,6 @@
#{{.Index}}
{{.Title}} - {{if .Ref}} - {{.Ref}} - {{end}} {{range .Labels}} {{.Name}} {{end}} @@ -208,6 +205,11 @@ {{else}} {{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName|Escape) | Safe}} {{end}} + {{if .Ref}} + + {{.Ref}} + + {{end}} {{$tasks := .GetTasks}} {{if gt $tasks 0}} {{$tasksDone := .GetTasksDone}} From d648922a9014820729ca5ee28117ce505b6f5f24 Mon Sep 17 00:00:00 2001 From: jaqra Date: Thu, 12 Sep 2019 08:45:59 +0300 Subject: [PATCH 4/5] [/issues page] Add milestone, Add Ref, Fix Assignees --- templates/user/dashboard/issues.tmpl | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/templates/user/dashboard/issues.tmpl b/templates/user/dashboard/issues.tmpl index 7083569164fb7..3e1095606b315 100644 --- a/templates/user/dashboard/issues.tmpl +++ b/templates/user/dashboard/issues.tmpl @@ -100,9 +100,19 @@ {{else}} {{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName|Escape) | Safe}} {{end}} - {{if .Assignee}} - - + {{if .Milestone}} + + {{.Milestone.Name}} + + {{end}} + {{if .Ref}} + + {{.Ref}} + + {{end}} + {{range .Assignees}} + + {{end}} {{$tasks := .GetTasks}} From 64e2c2512465dd06c07348154713875a88d3f49d Mon Sep 17 00:00:00 2001 From: jaqra Date: Thu, 12 Sep 2019 08:46:40 +0300 Subject: [PATCH 5/5] [repo issues page] reorder tasks, milestone and ref --- templates/repo/issue/list.tmpl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index 612b62ca8258c..4874d97da45aa 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -239,13 +239,6 @@ {{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName | Escape) | Safe}} {{end}} - {{$tasks := .GetTasks}} - {{if gt $tasks 0}} - {{$tasksDone := .GetTasksDone}} - - {{$tasksDone}} / {{$tasks}} - - {{end}} {{if .Milestone}} {{.Milestone.Name}} @@ -256,6 +249,13 @@ {{.Ref}} {{end}} + {{$tasks := .GetTasks}} + {{if gt $tasks 0}} + {{$tasksDone := .GetTasksDone}} + + {{$tasksDone}} / {{$tasks}} + + {{end}} {{if ne .DeadlineUnix 0}} {{.DeadlineUnix.FormatShort}}