Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Checkbox at RepoSetting for CI does not work #8512

Closed
6543 opened this issue Oct 14, 2019 · 3 comments · Fixed by #8799
Closed

[Bug] Checkbox at RepoSetting for CI does not work #8512

6543 opened this issue Oct 14, 2019 · 3 comments · Fixed by #8799
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@6543
Copy link
Member

6543 commented Oct 14, 2019

I'll update this issue later on - short description

the checkbox of an CI in the settings (protected branch) dont behave like has no function

either make a list

  • with
  • souch points

or give the a function (only if checked CI will be checked/has to aprove PR)

@6543 6543 changed the title [note] CI setting is iretating CI setting is iretating Oct 22, 2019
@6543
Copy link
Member Author

6543 commented Oct 23, 2019

Bildschirmfoto zu 2019-10-23 00-06-37

-> is this aktive or not ?

= it is ...

@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Oct 23, 2019
@6543
Copy link
Member Author

6543 commented Nov 2, 2019

templates/repo/settings/protected_branch.tmpl: L135

<input class="enable-whitelist" name="status_check_contexts" value="{{.}}" type="checkbox" {{if $.is_context_require}}{{if call $.is_context_required .}}checked{{end}}{{end}}>

@lafriks @lunny you added/changed this code at #7481 do you have any idears why this happens?

@6543
Copy link
Member Author

6543 commented Nov 2, 2019

I found a wrong var: #8799

but i can NOT test, if this will fix it (have no local CI running), I can verify if patch is aplyed to gitea.com :(

EDIT: I can ... (note for other devs:)

fake a CI status using the API http://<your-gitea-server>/api/swagger#/repository/repoCreateStatus
{
  "context":"fake-context",
  "description": "fake-description",
  "state": "success",
  "target_url": "https://gnu.org"
}

+ ApiTocken

@6543 6543 changed the title CI setting is iretating [Bug] Checkbox at RepoSetting for CI does not work Nov 3, 2019
@lunny lunny added type/bug and removed type/enhancement An improvement of existing functionality labels Nov 3, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants