Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parser when having link lists as TOC #7629

Closed
flobee opened this issue Jul 26, 2019 · 6 comments
Closed

Markdown parser when having link lists as TOC #7629

flobee opened this issue Jul 26, 2019 · 6 comments

Comments

@flobee
Copy link

flobee commented Jul 26, 2019

Hello all

I found out that gitea not always renders markdown (e.g. README.md file) as expected for internal link/ankers when using a table of contents generator.
It works and it doesnt.

Maybe a restriction in length or incomplete parser? See link above.

The only difference in my examples: The one that dont work has only one root element.
The working example has mor than one. Dropping a first level solves it but i think this is unusual or am i wrong?

Kind regards florian

@silverwind
Copy link
Member

Your example is 404.

@flobee
Copy link
Author

flobee commented Jul 26, 2019

Your example is 404.

Try this [1], i updated the link an hour ago because it was the edit link
[1] https://try.gitea.io/company/markdown-checks/src/branch/master/README.md

Now it works: it was private! sorry!

@mrsdizzie
Copy link
Member

mrsdizzie commented Jul 26, 2019

It is a little hard to follow the description but I think this is maybe the upstream issue with the markdown renderer we use:

russross/blackfriday#329

Seems to be that it sets tabs to size of 4 spaces, not two despite two being standard for other markdown renderers

@flobee
Copy link
Author

flobee commented Sep 11, 2019

@mrsdizzie Yes, you are right! I could try to send the number space chars i set to make it clear! Sry!!! i' updated my rules for 3 chars indent using the doctoc tool, which currently works.. in other situations things dont work. I try to make the report better next time.

Kind regards Florian

@stale
Copy link

stale bot commented Nov 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 10, 2019
@stale
Copy link

stale bot commented Nov 24, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Nov 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants