-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to load suppressed diffs #7341
Comments
When someone makes a large change, we need to be able to see it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
To avoid cluttering the diff view for the PR/commit/etc., this could be implemented with a page of its own; the commit diff page can provide a link in these cases so the user can open it in a new tab. |
@guillep2k is on to something here. Being able to diff between arbitrary commits would be great. One of the great features of gitea is the commit graph. A larger font and more whitespace should be used there to refine the UI. |
Tbh the whole diff generating structure needs review. Huge diffs that don't change lots of files are not truncated and in fact are read completely into memory affecting both the server and the client's ability to function. With any sensible rearchitecture we'll be able to grab extra diffs but it's getting the time to do this. (This is what I mean when I say the compare endpoint needs to be completely reviewed - there are serious flaws at every point.) |
Chiming in that I need this, since it's causing problems in that I can't put comments on specific lines in PRs. |
Has there been any development on this? |
I am currently looking (again) at this - part of the problem is that our code for generating compare pages is rather complex and altogether too interrelated. This PR fixing this will be big and require lots of time. |
I think we should aim to have the same mechanism to generate diffs and code view outputs. There currently seem to be two mechanisms at work which also product differences in syntax highlighting and such, for example #16434 (comment). |
Currently if a diff is suppressed because it's too large there is no way to load it like GitHub does:
Gitea:
GitHub:
The text was updated successfully, but these errors were encountered: