Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load suppressed diffs #7341

Closed
silverwind opened this issue Jul 2, 2019 · 10 comments
Closed

Add option to load suppressed diffs #7341

silverwind opened this issue Jul 2, 2019 · 10 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@silverwind
Copy link
Member

silverwind commented Jul 2, 2019

Currently if a diff is suppressed because it's too large there is no way to load it like GitHub does:

Gitea:
Screenshot 2019-07-02 at 10 23 19

GitHub:
Screenshot 2019-07-02 at 10 23 47

@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 2, 2019
@br-aw
Copy link

br-aw commented Jul 2, 2019

When someone makes a large change, we need to be able to see it.

@stale
Copy link

stale bot commented Aug 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 31, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 31, 2019
@stale stale bot removed the issue/stale label Aug 31, 2019
@guillep2k
Copy link
Member

To avoid cluttering the diff view for the PR/commit/etc., this could be implemented with a page of its own; the commit diff page can provide a link in these cases so the user can open it in a new tab.

@brandonkal
Copy link

brandonkal commented Oct 25, 2019

@guillep2k is on to something here. Being able to diff between arbitrary commits would be great.

One of the great features of gitea is the commit graph. A larger font and more whitespace should be used there to refine the UI.

@zeripath
Copy link
Contributor

Tbh the whole diff generating structure needs review.

Huge diffs that don't change lots of files are not truncated and in fact are read completely into memory affecting both the server and the client's ability to function.

With any sensible rearchitecture we'll be able to grab extra diffs but it's getting the time to do this.

(This is what I mean when I say the compare endpoint needs to be completely reviewed - there are serious flaws at every point.)

@iarepandemonium
Copy link

Chiming in that I need this, since it's causing problems in that I can't put comments on specific lines in PRs.

@lorenzocasasanta
Copy link

lorenzocasasanta commented Aug 11, 2021

Has there been any development on this?

@zeripath
Copy link
Contributor

I am currently looking (again) at this - part of the problem is that our code for generating compare pages is rather complex and altogether too interrelated.

This PR fixing this will be big and require lots of time.

@silverwind
Copy link
Member Author

silverwind commented Aug 12, 2021

I think we should aim to have the same mechanism to generate diffs and code view outputs. There currently seem to be two mechanisms at work which also product differences in syntax highlighting and such, for example #16434 (comment).

@delvh
Copy link
Member

delvh commented Apr 29, 2023

Has been implemented by now:
image

@delvh delvh closed this as completed Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

10 participants