Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding issue dependencies is defunct in 1.6.0 #5483

Closed
1 of 7 tasks
tinxx opened this issue Dec 6, 2018 · 6 comments
Closed
1 of 7 tasks

Adding issue dependencies is defunct in 1.6.0 #5483

tinxx opened this issue Dec 6, 2018 · 6 comments
Labels
issue/duplicate The issue has already been reported. type/bug

Comments

@tinxx
Copy link

tinxx commented Dec 6, 2018

  • Gitea version (or commit ref):
  • Git version: 1.6.0
  • Operating system: Debian Buster
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Can you confirm that adding dependencies is broken in Gitea version 1.6.0?

When trying to add a dependent issue to another issue I always get the result:

No results found.

I get the following message when I try adding a dependency by it's id (11 or #11).

Dependent issue does not exist.

Screenshots

screenshot from 2018-12-06 16-58-01
screenshot from 2018-12-06 16-58-10

@lunny lunny added the type/bug label Dec 8, 2018
@Akcaxup
Copy link

Akcaxup commented Dec 8, 2018

On PostgreSQL also
2580 _cr

@MarkusAmshove
Copy link
Contributor

Thie is a duplicate of #5389

@lunny
Copy link
Member

lunny commented Dec 8, 2018

@tinxx please confirm #5392 fix this.

@tinxx
Copy link
Author

tinxx commented Dec 8, 2018

I can confirm that it is the same API error on my instance. I am not a Gitea developer though and cannot confirm if the patch solves the issue.

@MarkusAmshove
Copy link
Contributor

MarkusAmshove commented Dec 8, 2018

My workaround (which should be able to confirm if it is the same issue), which I'm not sure if it is recommended, is to create a file called sidebar.tmpl in custom/templates/repo/issue/view_content with this content.

The workaround is in this line.

Note that it is not quite the same change as in the PR, because I didn't also want to change the JS file.
I've added a / at the start to emulate the change in JS and changed RepoLink to RepoRelPath

If you look at the diff in the PR it shows the leading / in JS and change to RepoRelPath in the template.

@lafriks lafriks added the issue/duplicate The issue has already been reported. label Dec 9, 2018
@lafriks lafriks closed this as completed Dec 9, 2018
@tinxx
Copy link
Author

tinxx commented Dec 9, 2018

I reviewed the differences between your version and 1.6.0 version and found that only the / was added (next to format changes).

Adding the slash really fixed the problem for me. There are, however, strange layout glitches:
screenshot from 2018-12-09 10-44-41

What's more, I tried adding #31 as dep for #32 but the menu only allowed me to add #32 itself: Whenever I type #31 into the dependencies filter / search field of ticket #32, it displays only #32. 😕

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported. type/bug
Projects
None yet
Development

No branches or pull requests

5 participants