Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review not marked as outdated after file deletion #5417

Closed
2 of 7 tasks
iyzana opened this issue Nov 27, 2018 · 2 comments · Fixed by #8751
Closed
2 of 7 tasks

Review not marked as outdated after file deletion #5417

iyzana opened this issue Nov 27, 2018 · 2 comments · Fixed by #8751
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.11.0

Comments

@iyzana
Copy link
Contributor

iyzana commented Nov 27, 2018 •
edited
Loading

  • Gitea version (or commit ref): 1.11.0+dev-120-gac6accef0 (exists since 0da8bc9 / tag v1.6.0)
  • Git version: 2.15.3
  • Operating system: gitea docker container
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Steps to reproduce:

  • create a new pr, which adds a new file
  • add a review to that file
  • delete the file again

Repro url: https://try.gitea.io/succcubbus/review-deletion-outdated-repro/pulls/3

Expected:

  • review is marked as outdated

Actual:

  • review is still shown fully
@stale
Copy link

stale bot commented Jan 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 27, 2019
@adelowo
Copy link
Member

adelowo commented Jan 28, 2019

Yet another valid bug :)

@techknowlogick techknowlogick added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Jan 28, 2019
@iyzana iyzana mentioned this issue Oct 30, 2019
Merged
@lafriks lafriks added this to the 1.11.0 milestone Oct 31, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Mark review comment as invalidated when file is deleted iyzana/gitea
4 participants
@techknowlogick @lafriks @adelowo @iyzana