Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSPI logins don't redirect away from sign-in page #29116

Closed
Craig-Holmquist-NTI opened this issue Feb 9, 2024 · 2 comments · Fixed by #29583
Closed

SSPI logins don't redirect away from sign-in page #29116

Craig-Holmquist-NTI opened this issue Feb 9, 2024 · 2 comments · Fixed by #29583
Labels
Milestone

Comments

@Craig-Holmquist-NTI
Copy link

Description

With 1.21.5, after logging in through SSPI, the login succeeds, but the user remains on the sign-in page instead of redirecting to the home page.

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Before logging in:
before_login

Immediately after logging in with SSPI:
after_login

Screenshots are from Edge 121 but happens with multiple browsers.

Git Version

2.39.1

Operating System

Windows Server 2019

How are you running Gitea?

gitea-1.21.5-windows-4.0-amd64.exe downloaded from Github.

Database

SQLite

@wxiaoguang
Copy link
Contributor

I think it is related to #26105 . After that change, if the user has signed in, then "/user/login" should also redirect.

@wxiaoguang
Copy link
Contributor

After this fix: Make "/user/login" page redirect if the current user has signed in #29583 , maybe this problem could be resolved.

@lunny lunny added this to the 1.21.8 milestone Mar 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants