Add number of repos for every filter type

[Morlinest]

Hi, what do you think about little improvement of UI (introduced in #2285):

or with grey color

Any comment or idea is welcome.

[lafriks]

Grey looks better. Also I think numbers should be lower like it is in my repositories count above.

[Morlinest]

@lafriks Like this? Doesn't fit to screen well.

[Morlinest]

I was looking at github dashboard. They have filters too, but each filter do own search. Our filter only filters result of search "all" repositories. I can rework rest api and add type to query options.

[daviian]

In my opinion numbers are too much. Why not just greyish the filter which does not have any results, don't disable the button, only greyish to give a visual hint?

[lafriks]

I also does not like how it looks... Numbers makes interface with too much information. I agree that filters on each tab does need to perform it's own query as otherwise if you could get wrong information about your repositories if you are hitting page size limit

[Morlinest]

@daviian @lafriks I agree with you both. I'll try to change search of repositories first, each filter should do own search. Also I have some idea how to make it effective (and after testing on github I found that they had same idea :D)

Edit: Not exactly the same idea (also some bugs there).

[Morlinest]

I have some updates. First, with #2326 it's possible to do search for each filter, it can looks like this:

1. Without "counter" (same as now, but with custom search)
   

2. Without "counter", with additional loader
   

3. Can be same as 2 or 3, but with count of repositories for actual filter and searchQuery
   
   
   

"Show more repositories" text is shown when actual search hits limit.

What do you think guys?

[lafriks]

that looks good 👍

[Morlinest]

@lafriks Which one looks best?

1. With or without additional loader?
2. With or without number of repositories?

[lafriks]

@Morlinest with loader & with total repository count

[daviian]

@Morlinest One small approvement would be to show a little spinner (or something else) while searching instead of a zero count ;-)

[lafriks]

No more spinners, two are already enough :) Just show count label only when data is loaded

[Morlinest]

Closed by #2343