Not building frontend (fast-glob is missing)

[finalclass]

Description

Steps I took:

1. Cloned the recent repo
2. executed TAGS="bindata sqlite sqlite_unlock_notify" make frontend
3. This error showed up:

$ TAGS="bindata sqlite sqlite_unlock_notify" make frontend
go run github.com/google/go-licenses@v1.3.0 save . --force --save_path=".go-licenses" 2>/dev/null
make: [Makefile:426: assets/go-licenses.json] Error 1 (ignored)
node build/generate-go-licenses.js ".go-licenses" "assets/go-licenses.json"
node:internal/errors:465
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'fast-glob' imported from /home/sel/Documents/tmp/gitea/build/generate-go-licenses.js
    at new NodeError (node:internal/errors:372:5)
    at packageResolve (node:internal/modules/esm/resolve:954:9)
    at moduleResolve (node:internal/modules/esm/resolve:1003:20)
    at defaultResolve (node:internal/modules/esm/resolve:1218:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:580:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:294:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:80:40)
    at link (node:internal/modules/esm/module_job:78:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}
make: *** [Makefile:427: assets/go-licenses.json] Error 1

As a work around I entered the build directory and installed the fast-glob package like this:

cd build
npm i fast-glob

and then the build was successful.

Gitea Version

f1ea6c9

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

linux manjaro

How are you running Gitea?

$ uname -a
Linux rog 5.15.60-1-MANJARO #1 SMP PREEMPT Thu Aug 11 13:14:05 UTC 2022 x86_64 GNU/Linux
$ go version
go version go1.19 linux/amd64
$ node --version
v16.15.1

Database

SQLite

[delvh]

Will be fixed by #21078.

[silverwind]

It's a make dependency issue, you can workaround using make deps-frontend frontend

[delvh]

#21078 has been merged now.