Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Show rendered file in plain mode #20437

Closed
r10r opened this issue Jul 21, 2022 · 8 comments
Closed

Question: Show rendered file in plain mode #20437

r10r opened this issue Jul 21, 2022 · 8 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@r10r
Copy link

r10r commented Jul 21, 2022

Description

How can I show a rendered file (e.g markdown) in plain mode ?

I need this to jump from an external search server zoekt to the line of a file which is rendered by default (e.g markdown files) or by an external renderer.

The answer should be added to https://docs.gitea.io/en-us/external-renderers/.

E.g gitub allows to disable rendering and shows the source blob when the
URL attribute plain=1 is append.

https://github.com/sourcegraph/zoekt/blob/master/doc/indexing.md?plain=1

Screenshot 2022-07-21 at 17 48 10

Gitea Version

1.16.8

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

helm chart

Database

No response

@r10r r10r added the type/bug label Jul 21, 2022
@r10r r10r changed the title Question: Question: Show rendered file in plain mode Jul 21, 2022
@silverwind silverwind added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/bug labels Jul 21, 2022
@silverwind
Copy link
Member

silverwind commented Jul 21, 2022

PR welcome, I suppose. There might be an already open issue for this feature somewhere, but I can't find it.

@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 21, 2022
@silverwind
Copy link
Member

Actually, this is already implemented via adding ?display=source.

@r10r
Copy link
Author

r10r commented Jul 22, 2022

Nice! It's working in the demo instance, but not in my installation 1.16.8.
I looked at the changelog and diff from 1.16.8 to 1.16.9 and haven't noticed a relevant change.
@silverwind Is there any additional setting required or do I have to upgrade to 1.16.9 ?
Thanks!

@zeripath
Copy link
Contributor

You would need to try 1.17-rc2

@r10r
Copy link
Author

r10r commented Jul 22, 2022

Cool. I'll wait for 1.17 then. Thanks for the hint!

@zeripath
Copy link
Contributor

Honestly consider trying 1.17-rc2 or even just run off the 1.17 release branch (1.17-dev in docker speak) - if no one tries it we'll never find the bugs.

@wxiaoguang
Copy link
Contributor

The feature is in 1.17

And 1.17-rc2 is very stable now, I highly recommend you to use it.

@r10r
Copy link
Author

r10r commented Jul 22, 2022

if no one tries it we'll never find the bugs.

You're right. I'm using the helm chart for deployment.
Can I simply update the image tag in the helm chart values then?

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

4 participants