Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The webhook related API cannot cover all events in the update scenario #19250

Closed
XiaoBoya opened this issue Mar 29, 2022 · 0 comments · Fixed by #19251
Closed

The webhook related API cannot cover all events in the update scenario #19250

XiaoBoya opened this issue Mar 29, 2022 · 0 comments · Fixed by #19251
Labels

Comments

@XiaoBoya
Copy link

Description

https://github.com/go-gitea/gitea/blob/main/routers/api/v1/utils/hook.go
In the addHook method, if the passed parameter includes pull_request, all events related to pr will be checked. But there is no way to select events such as PullRequestSync in editHook. This results in no way to manipulate all events through the update operation when updating the webhook.

Gitea Version

branch:master

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

PostgreSQL

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant