Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Mentioning a deleted user ghost results into 404 #18602

Closed
schorsch13 opened this issue Feb 4, 2022 · 2 comments
Closed

[Bug Report] Mentioning a deleted user ghost results into 404 #18602

schorsch13 opened this issue Feb 4, 2022 · 2 comments
Labels
topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@schorsch13
Copy link
Contributor

Introduction

If you mention a deleted user @ghost who is actually proposed if a ghost user is in your current issue conversation, it creates a link to that non-existent user resulting in a 404 error page.

The name Ghost is also pretty confusing and could be renamed to Deleted User or something.

Proposal

This issue can be resolved either by checking if a mentioned user (even if a username) (still) exists and only link to that profile if it does or by displaying an information like "This user has been deleted" in case of a ghost user.

Credits

This bug was discovered my the codeberg user fnetX. For further information have a look at the issue on codeberg: https://codeberg.org/Codeberg/Community/issues/361

@fnetX
Copy link
Contributor

fnetX commented Feb 4, 2022

I assigned myself to the downstream issue as I planned to add a "This user is a ghost" page to Gitea, it's about position 4 on my backlog :)

If someone decides to rather implement the user checking to avoid links to /ghost, I'm happy about that, too, but I won't find time for that solution.

@a1012112796 a1012112796 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 5, 2022
@6543 6543 added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label May 20, 2022
@yardenshoham
Copy link
Member

Fixed by #21554?

@lunny lunny closed this as completed Nov 16, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

6 participants