Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring tool codecov #18457

Closed
6543 opened this issue Jan 30, 2022 · 5 comments
Closed

Monitoring tool codecov #18457

6543 opened this issue Jan 30, 2022 · 5 comments
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.

Comments

@6543
Copy link
Member

6543 commented Jan 30, 2022

Discussion:

  • remove code coverage monitoring at all
  • find a solution that works on gitea.com too

-> #18443 (comment)
-> #18443 (review)

@6543
Copy link
Member Author

6543 commented Jan 30, 2022

cc @go-gitea/maintainers

@wxiaoguang
Copy link
Contributor

I am fine with either keeping (not bad) or removing (no help, maybe no one really looks into it)

@delvh
Copy link
Member

delvh commented Jan 30, 2022

I am in favor of removing it entirely for the following reasons:
a) I dislike that on every single PR, such a comment will be generated. This makes scrolling in a PR a pain, especially for small PRs simply because of the comment size. (It is larger than a screen is high)
b) I don't understand its algorithm/ information. I have seen coverage changes in PRs that were only adjusting the documentation. Why would the coverage differ in such a case? That seems counter-intuitive to me explained by @zeripath, see below
c) I have never looked at it at all, despite being present in every PR. Partially because of the reasons mentioned above.

@zeripath
Copy link
Contributor

The coverage is slightly different each time the test-suite is run due to the inherent non-determinism in the integration test cases.

The problem is that no-one (including myself) is looking at the coverage or trying to actively increase it or work on preventing coverage getting lower.

@6543
Copy link
Member Author

6543 commented Jan 30, 2022

I personally find the report on pulls useless but tho monitor the trend important...

@zeripath zeripath added the type/question Issue needs no code to be fixed, only a description on how to fix it yourself. label Jan 30, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.
Projects
None yet
Development

No branches or pull requests

5 participants