Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag push creates webhook with empty commits and head_commit #18112

Closed
DoLearnWhileAlive opened this issue Dec 27, 2021 · 3 comments · Fixed by #18116
Closed

Tag push creates webhook with empty commits and head_commit #18112

DoLearnWhileAlive opened this issue Dec 27, 2021 · 3 comments · Fixed by #18116
Milestone

Comments

@DoLearnWhileAlive
Copy link

Gitea Version

1.15.8

Git Version

2.33.1

Operating System

Windows Server 2016

How are you running Gitea?

based on gitea-1.15.8-windows-4.0-amd64.exe as Windows Service

Database

SQLite

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

Creating a new tag for a gitea repo creates a webhook with empty commits and head_commit. See example from gitea demo site:

{
  "ref": "refs/tags/v1.1.1",
  "before": "0000000000000000000000000000000000000000",
  "after": "3f150d39b92dd50cdd0248f5edea5767c2172584",
  "compare_url": "https://try.gitea.io/",
  "commits": [],
  "head_commit": null,
  "repository": {
  ...

I have an on-prem gitea instance connected with on-prem AppVeyor server. AppVeyor can't create new builds if commits and head_commit are empty, see also open issue on AppVeyor: appveyor/ci#3765

Screenshots

No response

@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 31, 2021

@DoLearnWhileAlive Does AppVeyor work now?

@DoLearnWhileAlive
Copy link
Author

Just tested newest Gitea main build (1.16.0+dev-785-g496acbe9e) and AppVeyor is still not triggering a new build for a new tag. AppVeyor seems to expect both commits and head_commit to be defined.

@DoLearnWhileAlive
Copy link
Author

DoLearnWhileAlive commented Jan 3, 2022

@KN4CK3R AppVeyor Server was updated with version 7.0.3134 to support head_commit in the webhook payload. With that change AppVeyor Server is creating a build for a Gitea tag webhook again. See also appveyor/ci#3765.
Thanks for fixing the Gitea part!

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants