Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When creating PRs, reload diffs in background #16159

Closed
nils91 opened this issue Jun 15, 2021 · 1 comment
Closed

[Feature Request] When creating PRs, reload diffs in background #16159

nils91 opened this issue Jun 15, 2021 · 1 comment
Labels
performance/speed performance issues with slow downs type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@nils91
Copy link
Contributor

nils91 commented Jun 15, 2021

Description

When creating a new pull request using the UI, Gitea will reload the page every time when the selected branch(es) are changed through the dropdowns to display the diff (and relevant commits) between those 2 branches. That can take time, especially for large diffs. During that time, seemingly nothing happens.
It would probably be better if Gitea would reload the diff in background and display a simple loading animation to the user until the diff is ready.

Screenshots

pr
On the screengrab it doesn´t look so bad, but for larger diffs that can take several minutes. The screengrab is from try.gitea.io ( https://try.gitea.io/nils91/test ).

@a1012112796 a1012112796 added type/proposal The new feature has not been accepted yet but needs to be discussed first. performance/speed performance issues with slow downs labels Jun 15, 2021
@jpraet
Copy link
Member

jpraet commented Jun 15, 2021

Duplicate of #13949

@nils91 nils91 closed this as completed Jun 15, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance/speed performance issues with slow downs type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants