Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due Date Format for Milesones #15635

Closed
2 of 6 tasks
tcpluess opened this issue Apr 27, 2021 · 8 comments
Closed
2 of 6 tasks

Due Date Format for Milesones #15635

tcpluess opened this issue Apr 27, 2021 · 8 comments
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@tcpluess
Copy link

The date formats for milestones are inconsistent.
For the due date, the mm/dd/yyyy format is used, whereas the normal yyyy-mm-dd is used in the milestones overview.
There should be an option to change the date format.

  • Gitea version (or commit ref): 1.14.1
  • Git version: 2.30.2
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (any repo)
    • No
  • Log gist:

Description

...

image

image

Screenshots

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Apr 27, 2021
@silverwind
Copy link
Member

silverwind commented Apr 27, 2021

The date input is locale-aware but our date/time rendering is not. This will require a big overhaul of our timestamp rendering and would likely require it to be done in JavaScript, like Github does.

@tcpluess
Copy link
Author

OK I can understand that this change will not happen in the near future. However on the other hand we could argue that there is an actual ISO standard about how dates should be written:

https://en.wikipedia.org/wiki/ISO_8601

in that case it would not be necessary to use locale-aware date/time format, one could just stick to the ISO standard.

@silverwind
Copy link
Member

silverwind commented Apr 29, 2021

I think generally we want to render timestamps in relative format (which should be locale-independent strings) with absolute date in a tooltip (which can be locale-dependant).

Thought I do see a reason to render Milestone Due dates as absolute, Github does it too (Due by July 29, 2021).

@yardenshoham
Copy link
Member

Fixed in #23988?

@silverwind
Copy link
Member

I'd say so as we now render in the user's OS preference.

@delvh
Copy link
Member

delvh commented Apr 29, 2023

Isn't this issue actually talking about #24055 which was never merged and should thus be reopened?

@lunny lunny reopened this Apr 30, 2023
@lunny
Copy link
Member

lunny commented Apr 30, 2023

It's another date format used for due dates.

@yardenshoham
Copy link
Member

#24055 was replaced by #24275 so I think we can close it

@delvh delvh closed this as completed Apr 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

5 participants