Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace com.Expand #14760

Closed
jolheiser opened this issue Feb 20, 2021 · 2 comments
Closed

Replace com.Expand #14760

jolheiser opened this issue Feb 20, 2021 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Milestone
1.17.0

Comments

@jolheiser
Copy link
Member

Here is a search (on GH) of our usage of com.Expand.

We should think about replacing it with either template execution or os.Expand.

There isn't anything necessarily wrong with com.Expand, but an stdlib implementation would be nice, and it would be manageable to refactor now.
@jolheiser jolheiser added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Feb 20, 2021
@6543 6543 added this to the 1.15.0 milestone Feb 20, 2021
@zeripath zeripath modified the milestones: 1.15.0, 1.16.0 Jun 25, 2021
@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 9, 2021
@wxiaoguang
Copy link
Contributor

Finally, it's done in

@lunny
Copy link
Member

lunny commented Apr 2, 2022

A little problem is the syntax between vars/expand and os/expand is not the same. So that readme init placeholder syntax is not the same as template repository.

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

No branches or pull requests
5 participants
@lunny @zeripath @wxiaoguang @6543 @jolheiser