Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enter gopher hole in profile #14748

Closed
4y8 opened this issue Feb 19, 2021 · 5 comments · Fixed by #14749
Closed

Can't enter gopher hole in profile #14748

4y8 opened this issue Feb 19, 2021 · 5 comments · Fixed by #14749
Labels
type/enhancement An improvement of existing functionality
Milestone

Comments

@4y8
Copy link
Contributor

4y8 commented Feb 19, 2021

I would like to put a link to my gopher hole in the website section of my profile. However, when I enter its URL, it tells me that it's not a valid URL because is starts with gopher://.

@6543 6543 added the type/bug label Feb 19, 2021
@jolheiser
Copy link
Member

Here is the relevant code based on our form binding.

func IsValidURL(uri string) bool {
if u, err := url.ParseRequestURI(uri); err != nil ||
(u.Scheme != "http" && u.Scheme != "https") ||
!validPort(portOnly(u.Host)) {
return false
}
return true
}

@6543
Copy link
Member

6543 commented Feb 19, 2021

@yul3n if you like, you could file a pull for it ;) ☝️

@4y8
Copy link
Contributor Author

4y8 commented Feb 19, 2021

Here is the link to the pull request I made to add support fix it:
#14749

@4y8
Copy link
Contributor Author

4y8 commented Feb 19, 2021

Thanks for your support!

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality and removed type/bug labels Feb 22, 2021
@sikmir
Copy link

sikmir commented Apr 2, 2021

The same issue for gemini:// URL.

@6543 6543 added this to the 1.15.0 milestone Apr 3, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants