Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Comment - Reference in new issue #14315

Closed
kdumontnu opened this issue Jan 12, 2021 · 7 comments
Closed

[Feature Request] Comment - Reference in new issue #14315

kdumontnu opened this issue Jan 12, 2021 · 7 comments
Labels
issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kdumontnu
Copy link
Contributor

kdumontnu commented Jan 12, 2021

GitHub introduced a new feature to create a new issue from a PR comment.
53243733-97fdfa80-3687-11e9-9512-9aeb3c0ffa80
Clicking the option opens up a modal
53243797-c4197b80-3687-11e9-883a-9ed2a24cfd47

I've found this feature to be quite a time-saver, helpful for providing additional context for why the issue was opened, and helpful in continuing long discussions in PRs. Would be a great addition to see in Gitea.

Bountysource

@kdumontnu
Copy link
Contributor Author

kdumontnu commented Jan 12, 2021

Bounty available: https://www.bountysource.com/issues/95865752-feature-pull-request-comment-reference-in-new-issue

Requirements:

  • As in GH, user can select from the dropdown from any comment (PR or issue) to create a new issue from the comment, in which case the modal will display (as shown below)
  • As in GH, the Title should populate with the first X (80? or anything we use as default) characters of the first comment
  • As in GH, the Body should populate with all comments and the link to author & origin
  • Unlike GH, the option to create new issue should also be included next to the option to "Resolve conversation" (as shown below)

Requested (but optional for bounty):

  • As in GH, the Repository can be selected from a dropdown in the modal and by default uses the current repository

image (14)

@kdumontnu kdumontnu changed the title Feature: Pull Request comment - Reference in new issue [Feature Request] Comment - Reference in new issue Jan 12, 2021
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 13, 2021
@techknowlogick techknowlogick added issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 13, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 16, 2021

I have implemented this feature in https://github.com/KN4CK3R/gitea/tree/feature-reference-in-issue

Unlike GH, the option to create new issue should also be included next to the option to "Resolve conversation" (as shown below)

What if there are multiple comments? Which text should be used to create the issue? On the Files Changed tab you can create issues from single comments:
grafik

@kdumontnu
Copy link
Contributor Author

Awesome!

What if there are multiple comments? Which text should be used to create the issue? On the Files Changed tab you can create issues from single comments:

I would default to the first comment in the Title and the whole comment thread in the body of that's what you mean.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 17, 2021

How about this:
grafik

I have implemented the contex menu bubbles on file comments. Now it works like in all other places.

@kdumontnu
Copy link
Contributor Author

@KN4CK3R I just realized that in GH you can also reference code in new issues (see below). I decided to post here to keep your existing PR clean. I think this can be resolved in a future PR, but I figured I'd let you know in case you wanted to tackle it now.
image

@6543
Copy link
Member

6543 commented Jan 21, 2021

closed with #14366 by @KN4CK3R

@6543 6543 closed this as completed Jan 21, 2021
@6543
Copy link
Member

6543 commented Jan 21, 2021

@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants