Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror release commit count issue #13398

Closed
4 tasks done
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Nov 2, 2020 · 4 comments
Closed
4 tasks done

Mirror release commit count issue #13398

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Nov 2, 2020 · 4 comments
Labels

Comments

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

  • Gitea version (or commit ref): Gitea version 1.14.0+dev-132-g8176ba657 built with GNU Make 4.3, go1.15.3 : bindata, sqlite, sqlite_unlock_notify
  • Git version: git version 2.29.2.222.g5d2a92d10f
  • Operating system: Arch Linux
  • Database:
    • SQLite
  • Build from source:
    • Yes
  • Run with:
    • systemd
  • Can you reproduce the bug at https://try.gitea.io:

Description

I believe the commit count in the release area of a mirror is off.
For instance while the release page of a go-gitea/gitea mirror shows there have been 0 commits to master since v1.14.0-dev, the Gitea version string (1.14.0+dev-132-g8176ba657) says there in fact have been 132 commits to master.
I think the latter is correct.

Screenshots

my instance:
image
try.gitea.io
image

@6543 6543 added the type/bug label Nov 5, 2020
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor Author

this still holds btw, even with great improvements to the UI such as #13428 ("Tags cleanup").
The count is still off.

@conor-byrne
Copy link

Has anyone else noticed negative commit count? The tag is also on a different branch to master in my case.

image

Version: 1.15.0+dev-189-gcc7d118b1

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor Author

Currently running Gitea Version: 1.15.0+dev-188-gf31443d6a I can't reproduce the original issue anymore, probably because the tags/releases pages there have undergone some changes and the "$X commits to $branch since this release" isn't even displayed for mirrors.

Note that initially the issue was only pertaining mirrored repositories.

I haven't come across your issue yet (looks like this is a regular repository, not a mirror), although that'd probably presume me reproducing the commit count etc. @conor-byrne

Just out of curiosity, what happens when you tag a commit that's 256 commits behind current HEAD? How will Gitea display that?

Smaller number (37<256<272) gets shown just fine
image
EDIT: screenshot is from a regular repo's Releases page.

@lunny
Copy link
Member

lunny commented Mar 8, 2024

Close as outdated. Please open a new issue if this happen again.

@lunny lunny closed this as completed Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants