Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for provider: IBM Cloud (SoftLayer) #1486

Closed
5 tasks done
nonchan7720 opened this issue Sep 10, 2021 · 4 comments · Fixed by #1487
Closed
5 tasks done

Support for provider: IBM Cloud (SoftLayer) #1486

nonchan7720 opened this issue Sep 10, 2021 · 4 comments · Fixed by #1487

Comments

@nonchan7720
Copy link
Contributor

nonchan7720 commented Sep 10, 2021

Welcome

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, the DNS provider exposes a public API.
  • Yes, I know that the lego maintainers don't have an account in all DNS providers in the world.
  • Yes, I'm able to create a pull request and be able to maintain the implementation.
  • Yes, I'm able to test an implementation if someone creates a pull request to add the support of this DNS provider.

How do you use lego?

Docker image

Link to the DNS provider

https://cloud.ibm.com/docs/dns

Link to the API documentation

https://cloud.ibm.com/docs/dns?topic=dns-getting-started-with-the-dns-api

Additional Notes

I'm sorry I'm not good at English

Implementation is over.

I would like to make the first PR in my life
Can you guide me?

@ldez
Copy link
Member

ldez commented Sep 10, 2021

Hello,

I will help and guide you, no problem.

First, you can read the GitHub guide about PR: https://docs.github.com/ja/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

You have to create a dedicated branch (don't use the master branch)
And you will have to open a PR with this branch

After that, I will guide you on the PR.

@nonchan7720
Copy link
Contributor Author

@ldez

Thank you very much.

After forking, I created a branch and completed the implementation.

I would like to know the information necessary for PR.

@ldez
Copy link
Member

ldez commented Sep 10, 2021

The requirements are here #1473 (comment)

@nonchan7720
Copy link
Contributor Author

@ldez

I just issued a PR, so please check it.

@ldez ldez changed the title Support for provider: softlayer(IBM Cloud Domain Name Registration) Support for provider: IBM Cloud (SoftLayer) Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants