We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait.For returns nil error if deadline exceeded
wait.For
If certificate got deadline For() returns nil error wrapped by fmt:
For()
obtaining certificate: error: one or more domains had a problem: [example.com] time limit exceeded: last error: %!w(<nil>)
So, this is not good: it's way more better if we can replace timeout to context and return DeadlineExceeded or bare error which returns from callback
wait.For()
discovered on v4.2.0 reproduces as well on v4.3.1
v4.2.0
v4.3.1
The text was updated successfully, but these errors were encountered:
how fast lego developers are:
Thanks a lot for this fix! You rock guys, love this project
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
What did you expect to see?
wait.For
returns nil error if deadline exceededWhat did you see instead?
If certificate got deadline
For()
returns nil error wrapped by fmt:So, this is not good: it's way more better if we can replace timeout to context and return DeadlineExceeded or bare error which returns from callback
Steps to reproduce
wait.For()
some callback, which never returns any errorDetails
Version of lego
discovered on
v4.2.0
reproduces as well onv4.3.1
Logs
no any logs, idkThe text was updated successfully, but these errors were encountered: