Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot set severity of issues from config file with different name #124

Open
0xtekgrinder opened this issue Feb 5, 2025 · 2 comments
Labels
A-lint Adding or updating lint bug bug P-high Priority: High

Comments

@0xtekgrinder
Copy link
Contributor

Currently with tlin, we have a few rules creating issues with a different name than the rule.

For example "defer-issues" have these lint issues:

  • "defer-panic"
  • "defer-nil-func"
  • "return-in-defer"
  • "defer-in-loop"

But in the config file, we can only disabled rules with their identifiers".

This issue aims to fix this bug by letting users disable in their config files the issues identifiers directly

@0xtekgrinder
Copy link
Contributor Author

Actually with a bit more of thinking, I don't know if it is relevant.
I think a better way to approach the issue would be instead to try to split the rules while reusing a general codebase.

It will allow a better way to ignore rules and be more atomic for features.

Tell me what you think @notJoon

@notJoon notJoon added bug bug A-lint Adding or updating lint P-high Priority: High labels Feb 6, 2025
@notJoon
Copy link
Contributor

notJoon commented Feb 6, 2025

I think a better way to approach the issue would be instead to try to split the rules while reusing a general codebase.

@0xtekgrinder I agree. However, when separating each rule, we need to add functionality to prevent unncessary re-traversal of the AST. The reason for combining defer-related rules into one was to traverse them all at once.

This is partially related to #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Adding or updating lint bug bug P-high Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants