Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event for incoming ether transfer #209

Closed
rmeissner opened this issue May 5, 2020 · 0 comments · Fixed by #278
Closed

Event for incoming ether transfer #209

rmeissner opened this issue May 5, 2020 · 0 comments · Fixed by #278
Milestone
contracts-safe-1.3.0

Comments

@rmeissner
Copy link
Member

rmeissner commented May 5, 2020 •
edited
Loading

It would be nice to have an event for incoming ether transfers.

This was removed due to gas limitations from send and transfer (see ethereum/solidity#7455 for more details). This limitations might not be relevant as with EIP-2929 these issues will happen anyways (even without the event)
@rmeissner rmeissner added the future Features for next major contract version label May 5, 2020
@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Jan 18, 2021
@rmeissner rmeissner mentioned this issue Mar 17, 2021
Merged
rmeissner added a commit that referenced this issue Mar 19, 2021
@rmeissner
Closes #209: Add event for incoming eth (#278)
4831c5f
@rmeissner rmeissner removed the future Features for next major contract version label Mar 19, 2021
Uxio0 pushed a commit that referenced this issue May 6, 2021
@rmeissner @Uxio0
Closes #209: Add event for incoming eth (#278)
0eff104
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
@rmeissner
Closes safe-global#209: Add event for incoming eth (safe-global#278)
93ae3aa
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#209 from safe-global/propose-tx-delegates
d34b3a5 
Allow Safe delegates to propose transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.3.0
Development

Successfully merging a pull request may close this issue.

Closes #209: Add event for incoming eth safe-global/safe-smart-account
1 participant
@rmeissner