Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible that any state of the Safe can be read on-chain #201

Closed
rmeissner opened this issue Apr 19, 2020 · 0 comments · Fixed by #269
Closed

Make it possible that any state of the Safe can be read on-chain #201

rmeissner opened this issue Apr 19, 2020 · 0 comments · Fixed by #269
Milestone
contracts-safe-1.3.0

Comments

@rmeissner
Copy link
Member

rmeissner commented Apr 19, 2020 •
edited
Loading

Currently we don't expose every information a due to contract size limitations this becomes increasingly tricky.

Therefore we should implement a mechanism similar to the requireTxGas function that allows reading of the contract state by providing the reader logic to the Safe contract (the Safe contract then would perform a delegate call and return the response data while reverting).

This would minimize the code of the master copy while increasing the flexibility
@rmeissner rmeissner added the future Features for next major contract version label Apr 19, 2020
@rmeissner rmeissner mentioned this issue Apr 19, 2020
Closed
@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Jan 18, 2021
@rmeissner rmeissner mentioned this issue Mar 1, 2021
Merged
rmeissner added a commit that referenced this issue Mar 5, 2021
@rmeissner
Closes #201: Allow storage to be read on-chain (#269)
cc491fe
@rmeissner rmeissner removed the future Features for next major contract version label Mar 19, 2021
Uxio0 pushed a commit that referenced this issue May 6, 2021
@rmeissner @Uxio0
Closes #201: Allow storage to be read on-chain (#269)
76c5a62
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
@rmeissner
Closes safe-global#201: Allow storage to be read on-chain (safe-globa…
bd6bb7d 
…l#269)
fdarian pushed a commit to fdarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#201 from safe-global/dependabot/npm_an…
1bf5387 
…d_yarn/cross-fetch-2.2.6

Bump cross-fetch from 2.2.5 to 2.2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.3.0
Development

Successfully merging a pull request may close this issue.

Closes #201: Allow storage to be read on-chain safe-global/safe-smart-account
1 participant
@rmeissner