Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization in ERC1155's safeTransferFrom #94

Open
remedcu opened this issue May 21, 2020 · 1 comment
Open

Optimization in ERC1155's safeTransferFrom #94

remedcu opened this issue May 21, 2020 · 1 comment
Labels
enhancement New feature or request P3 Med/low - Nice to have

Comments

@remedcu
Copy link

remedcu commented May 21, 2020

Line 119 in ERC1155 can be rewritten as:

from == msg.sender || _operatorApprovals[from][msg.sender],

Where the == true part is not necessary, as if it is true, the condition will still work correctly, and the same for false value.
@remedcu
Copy link
Author

remedcu commented May 21, 2020

The same can be said in Line 154

@auryn-macmillan auryn-macmillan added enhancement New feature or request P3 Med/low - Nice to have labels Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3 Med/low - Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auryn-macmillan @remedcu