Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to remove prepareCondition function #68

Open
Georgi87 opened this issue Aug 7, 2019 · 1 comment
Open

Consider to remove prepareCondition function #68

Georgi87 opened this issue Aug 7, 2019 · 1 comment
Labels
enhancement New feature or request P3 Med/low - Nice to have

Comments

@Georgi87
Copy link
Contributor

Georgi87 commented Aug 7, 2019

Consider removing the prepareCondition function as there is no need to have the information provided in this function as part of the smart contract until the redemption process starts. This would save gas costs and allow counterfactual assumptions.
@cag
Copy link
Contributor

cag commented Aug 7, 2019

This issue requires #69

@cag cag mentioned this issue May 15, 2020
Open
@auryn-macmillan auryn-macmillan added enhancement New feature or request P3 Med/low - Nice to have labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P3 Med/low - Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Georgi87 @cag @auryn-macmillan