Improve AppStream Metadata

[lazyfrosch]

• https://appstream.debian.org/sid/main/issues/terminator.html
• https://salsa.debian.org/python-team/applications/terminator/-/blob/debian/master/debian/patches/appdata_improvement.patch
• https://salsa.debian.org/python-team/applications/terminator/-/blob/debian/master/debian/patches/appdata_in_metainfo.patch

[ghost]

Is there a problem resolving this issue?

[buhtz]

Hope it is OK that I don't open a new issue. I am in the middle of creating my own AppStream metadata and accidentally discovered some problems with your appstream metadata on Debian.

$ appstreamcli validate termina*xml
W: terminator.desktop:3: cid-desktopapp-is-not-rdns terminator.desktop
I: terminator.desktop:148: description-first-para-too-short The robot future of terminals
I: terminator.desktop:521: unknown-tag updatecontact
I: terminator.desktop:~: desktop-app-launchable-omitted
I: terminator.desktop:~: content-rating-missing

The primary problem is non-rdns <id>. In your case it usually would be io.github.gnome-terminator.terminator. An alternative is io.github.terminator. Important is that the first two components are derived from a real existing URL. It don't have to be Microsoft github. This decission is up to you as a maintainer.

The content-rating-missing can be fixed with this "empty" content rating.

    <!-- https://hughsie.github.io/oars/generate.html -->
    <content_rating type="oars-1.0" />

Your updatecontact is just a typo. Use <update_contact> (docu).

Add a <launchable> tag. e.g.

<launchable type="desktop-id">terminator.desktop</launchable>