Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nomenclatural code as a flag #267

Closed
gdower opened this issue Oct 23, 2024 · 3 comments
Closed

Adding nomenclatural code as a flag #267

gdower opened this issue Oct 23, 2024 · 3 comments

Comments

@gdower
Copy link
Contributor

gdower commented Oct 23, 2024

As a GNParser user, it would be useful to indicate the nomenclatural code that gnparser should use. For example, in botanical mode GNParser would interpret and normalize scientific names and authorships according to IPNI's style.

Some examples IPNI vs the current GNparser normalized form:

IPNI: Glaphyropteris simulans (Ching) H.Ito in Nakai & Honda
GNp: Glaphyropteris simulans (Ching) H. Ito ex Nakai & Honda

IPNI: Glaphyropteris (Fée) C.Presl ex Fée
GNp: Glaphyropteris (Fee) C. Presl ex Fée

IPNI: Hemionitis pinnata Hook.f.
GNp: Hemionitis pinnata Hook. fil.

IPNI: Dacrycarpus (Endl.) de Laub.
GNp: Dacrycarpus subgen. Endl. de Laub.

So it would mainly be taking out the space with C. Presl as C.Presl, not normalizing filius to fil. (e.g., Hook. fil. as Hook.f.), fixing the ex/in issue, and handling genus combination authorships. I'm not sure why GNp normalizes Fée to Fee in the original authorship. For handling genus combination authorships, often I know the rank with high confidence and could provide that as a parameter like &rank=genus to help GNp interpret it correctly although that might only work when parsing 1 name at a time.

It might still be useful to have an independent flag for f. to fil. normalization. While IPNI uses the f. for filius, normalizing to fil. could still be useful in some cases to disambiguate from f. for forma.

@dimus
Copy link
Member

dimus commented Oct 24, 2024

@gdower I think it is a great idea to add an option for GNparser to consider names to parse belonging to a code. Currently e already have Cultivar flag, so we can add Botanical and Zoological flags to it

@dimus
Copy link
Member

dimus commented Nov 11, 2024

@gdower I did not close the ticket, please close it if all works the way you expect, or write here if something is not right.

@dimus
Copy link
Member

dimus commented Nov 22, 2024

Implemented in v1.11.1

@dimus dimus closed this as completed Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants