Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More "nudum" names which don't parse correctly #207

Closed
tobymarsden opened this issue Nov 15, 2021 · 3 comments
Closed

More "nudum" names which don't parse correctly #207

tobymarsden opened this issue Nov 15, 2021 · 3 comments

Comments

@tobymarsden
Copy link

Here is a list of 119 names from World Flora Online and Plants of the World Online containing the epithet "nudum" which don't parse correctly. I'm happy to submit a PR which adds them to the existing list of "nudum" exceptions, if that is the best approach?

@dimus
Copy link
Member

dimus commented Nov 15, 2021

Thanks @tobymarsden, great list. I see that some of the names are infraspecific, that means the solution I have need to be extended for them, before all names were species. PR would be fantastic, or I can get to it at some point this week.

@tobymarsden
Copy link
Author

tobymarsden commented Nov 15, 2021

@dimus Sure thing; I'll work on a PR in the coming days.

I'm also seeing a bunch more names with non- epithets not parsing correctly; is there scope for changing the regex to only match non where it's not followed by a dash? Or is that likely to catch detritus that should be moved to the tail?

(I realize that golang's regex engine doesn't support negative lookaheads so this may not be sensibly possible anyway, though I'd look into it. Maybe even just non\s?)

@tobymarsden
Copy link
Author

@dimus sorry, one more thing. Would changing the nudum regex to only match nomen\s+nudum be too restrictive? I couldn't find any references to nudum without nomen in front but it wasn't an exhaustive search...

@dimus dimus closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants