-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to ignore imagesLoaded
#53
Comments
To confirm, imagesLoaded is not actually part of this addon at the moment and has to be used separately (as per advise here http://masonry.desandro.com/layout.html#imagesloaded)? If it is, what is the current default behaviour? |
@sparkrevolutions
Well, it waits for all images to load before doing the grid spacing. How do you mean it's not actually part of this addon? See:
Ember.run.scheduleOnce('afterRender', this, () => {
imagesLoaded(get(this, 'element'), () => {
if (masonry) {
masonry.reloadItems();
} else { The noticeable consequence in my case is that every item is drawn on top of each other and only once every image is loaded do the items pop into place. This looks very hacky to the user, so we need to hide the content until the masonry magic (and thus the loading of images) is finished. |
imagesLoaded
can quickly add a couple of seconds to aligning your lists. In some cases it is not necessary.I'd like to see an option specified to the helper (that defaults to
true
for backwards compatibility reasons) to skip waiting for images to load. E.g.:The text was updated successfully, but these errors were encountered: