Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1089: Enable ci jobs for crunch #16

Merged
merged 14 commits into from
Apr 5, 2024
Merged

CSUB-1089: Enable ci jobs for crunch #16

merged 14 commits into from
Apr 5, 2024

Commits on Apr 4, 2024

  1. Rename release related workflow to release.yml

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ff0e2f2 View commit details
    Browse the repository at this point in the history

  2. Copy over create_release.yml from upstream again where their tests are 

    because previous commits didn't leave this file alone but rather made
lots of changes into it and then subsequently removed it.
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3a7b993 View commit details
    Browse the repository at this point in the history

  3. Rename upstream create_release.yml into ci.yml 

    will add subsequent changes here to make tests trigger on each PR
however this is a good starting point
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    458572c View commit details
    Browse the repository at this point in the history

  4. Enable minimal testing on PRs 

    - cargo check
- cargo clippy
- cargo fmt
- cargo test
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d2c8cc5 View commit details
    Browse the repository at this point in the history

  5. Reformat with cargo fmt

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    80e8f19 View commit details
    Browse the repository at this point in the history

  6. Stricter checks in CI

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    39fc293 View commit details
    Browse the repository at this point in the history

  7. Remove unused imports

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    496e209 View commit details
    Browse the repository at this point in the history

  8. Silence warnings for unused variables 

    for the upstream code just prefix them with underscore to minimize
differences, for creditcoin/ just remove them
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7e5e40c View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary mut

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9b50a70 View commit details
    Browse the repository at this point in the history

  10. Allow 2 unused methods from upstream implementation

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    258dda2 View commit details
    Browse the repository at this point in the history

  11. Add rust-toolchain.toml and use the same rustc version in CI 

    because fmt and clippy appear to be slightly different from version to
version and we'd like to have consistency regardless of how or where
this is built
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5087bcb View commit details
    Browse the repository at this point in the history

  12. Reformat again with rustc 1.77.0

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9a538e3 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from clippy

    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9ba640d View commit details
    Browse the repository at this point in the history

  14. Adjust CRUNCH_CONFIG_FILENAME to point to an existing file 

    because .env.example has been removed in
ca51756
    @atodorov
    atodorov committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c3c72b0 View commit details
    Browse the repository at this point in the history