Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on WindowsServerCore container fails #1239

Closed
kristofdho opened this issue Dec 19, 2023 · 3 comments · Fixed by #1240
Closed

Build on WindowsServerCore container fails #1239

kristofdho opened this issue Dec 19, 2023 · 3 comments · Fixed by #1240
Labels
bug Something isn't working

Comments

@kristofdho
Copy link
Contributor

Build fails on WindowsServerCore container, because ie4uinit dos not exist. I have not yet found a way to install this into the container as it doesn't have a Desktop UI, and ie4uinit is part of UI related stuff.

Fix would be to check if ie4uinit exists, and not run it if it doesn't.
Alternatively, ignore exceptions if it doesn't run, as it's only cosmetic.

Expected Behavior

Build succeeds

Current Behavior

This piece of code crashes:

private void clearExplorerCache() throws IOException, InterruptedException {
ProcessRunner clearCache = new ProcessRunner("ie4uinit");
clearCache.addArg(findCacheFlag());
clearCache.runProcess("Clear Explorer cache");
}

Because ie4uinit does not exist.

Steps to Reproduce

Do a build on WindowsServerCore.

Your Environment

WindowsServerCore 2022 container, substrate 0.0.61

@kristofdho kristofdho added the bug Something isn't working label Dec 19, 2023
@jperedadnr
Copy link
Contributor

jperedadnr commented Dec 19, 2023

Yes, it makes sense what you propose about doing a check to se if ie4uinit exists, though it might be more simple to put that code inside a try-catch and just log a warning if the process runner fails? Do you want to take this?

@kkriske
Copy link
Contributor

kkriske commented Dec 20, 2023

@jperedadnr see attached PR.
FYI, this is not that urgent for us, since we need to support older plugin versions on our CI environment anyway. So as a workaround we've added a noop ie4uinit.exe on the PATH, which circumvents the issue.

@kkriske
Copy link
Contributor

kkriske commented Apr 28, 2024

@jperedadnr I'm sure your time is limited, but any chance to get this looked at? I'd like to get this included so we could possibly remove our workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants