-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying some stuff #1
Commits on May 9, 2020
-
[wallet] remove nLastResend logic
remove nLastResend because it's unnecessary now that rebroadcasts always happen at least 12 hours later
Configuration menu - View commit details
-
Copy full SHA for cdd3d38 - Browse repository at this point
Copy the full SHA cdd3d38View commit details
Commits on May 13, 2020
-
[rpc] add unbroadcast info to mempool entries and getmempoolinfo
- expose info about number of txns in unbroadcast set and whether a mempool entry's tx has passed initial broadcast - makes rpcs more informative and allows for more explicit testing, eg tracking if tx is in unbroadcast set before and after originating node connects to peers (adds this in mempool_unbroadcast.py) - adds mempool method InUnbroadcast to quickly query for tx inclusion in mempool's unbroadcast set
Configuration menu - View commit details
-
Copy full SHA for def0be7 - Browse repository at this point
Copy the full SHA def0be7View commit details -
[mempool] sanity check that all unbroadcast txns are in mempool
- before reattempting broadcast for unbroadcast txns, check they are in mempool and remove if not - this protects from memory leaks and network spam just in case unbroadcast set (incorrectly) has extra txns - check that tx is in mempool before adding to unbroadcast set to try to prevent this from happening
Configuration menu - View commit details
-
Copy full SHA for 324711a - Browse repository at this point
Copy the full SHA 324711aView commit details -
[test] wait for inital broadcast to complete before comparing mempool…
… entries - mempool entry 'unbroadcast' field changes when initial broadcast is complete, so anytime you want to compare mempool entries, wait for initial broadcast to complete ('unbroadcast' = False) otherwise it may change in between calls - mempool_packages.py needs to do this especially because it compares entries as a whole and compares getrawmempool with getmempoolentry
Configuration menu - View commit details
-
Copy full SHA for 4ebe10f - Browse repository at this point
Copy the full SHA 4ebe10fView commit details -
[rpc] add unbroadcast info to mempool entries and getmempoolinfo
- exposes info about number of txns in unbroadcast set and whether a mempool entry's tx has passed initial broadcast - makes rpcs more informative and allows for more explicit testing, eg tracking if tx is in unbroadcast set before and after originating node connects to peers (adds this in mempool_unbroadcast.py) - adds mempool method InUnbroadcast to quickly query for tx inclusion in mempool's unbroadcast set
Configuration menu - View commit details
-
Copy full SHA for 12d15bc - Browse repository at this point
Copy the full SHA 12d15bcView commit details -
[mempool] sanity check that all unbroadcast txns are in mempool
- before reattempting broadcast for unbroadcast txns, check they are in mempool and remove if not - this protects from memory leaks and network spam just in case unbroadcast set (incorrectly) has extra txns - check that tx is in mempool before adding to unbroadcast set to try to prevent this from happening
Configuration menu - View commit details
-
Copy full SHA for 19bc947 - Browse repository at this point
Copy the full SHA 19bc947View commit details -
[test] wait for inital broadcast to complete before comparing mempool…
… entries - mempool entry 'unbroadcast' field changes when initial broadcast is complete, so anytime you want to compare mempool entries, wait for initial broadcast to complete ('unbroadcast' = False) otherwise it may change in between calls - mempool_packages.py needs to do this especially because it compares entries as a whole and compares getrawmempool with getmempoolentry
Configuration menu - View commit details
-
Copy full SHA for b7fc327 - Browse repository at this point
Copy the full SHA b7fc327View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3829a4c - Browse repository at this point
Copy the full SHA 3829a4cView commit details