Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in JSON error checking #172

Closed
vyasr opened this issue Apr 1, 2019 · 1 comment · Fixed by #199
Closed

Bug in JSON error checking #172

vyasr opened this issue Apr 1, 2019 · 1 comment · Fixed by #199
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vyasr
Copy link
Contributor

vyasr commented Apr 1, 2019

Description

The rapidjson package does not have a decoder submodule. Since we don't have a corresponding compatibility layer, things like json.decoder.JSONDecodeError fail.

To reproduce

$ signac init json_decoder
$ signac find '{"x": True}'
27958648a9e57fcd66ae5e31ff3359e9
$ signac find '{"x": True}'  # This is invalid JSON, the expected behavior is to raise an error indicating that the JSON is invalid
Error: module 'signac.core.json' has no attribute 'decoder'  # The actual output
@csadorf csadorf added the bug Something isn't working label May 4, 2019
@csadorf csadorf added this to the v1.1.1 milestone May 24, 2019
@bdice
Copy link
Member

bdice commented May 26, 2019

Seems this was addressed in rapidjson here:
python-rapidjson/python-rapidjson@8c1f764
python-rapidjson/python-rapidjson#118

...and released about two weeks ago: https://github.com/python-rapidjson/python-rapidjson/blob/master/CHANGES.rst

Good things come to those who wait! That makes solving this issue a bit cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants