Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEV needs to be Iev #36

Closed
opoudjis opened this issue Jan 6, 2025 · 2 comments · Fixed by #38
Closed

IEV needs to be Iev #36

opoudjis opened this issue Jan 6, 2025 · 2 comments · Fixed by #38
Assignees
Labels
bug Something isn't working

Comments

@opoudjis
Copy link
Contributor

opoudjis commented Jan 6, 2025

In 2d783f7 in March, you have changed Iev to IEV in module names, without informing me, and without doing a gem release.

As a result, when I did an update to the gem and released it last week, this broke standoc.

I have spent the past half hour trying to change IEV back to Iev, and I cannot, the spec files keep complaining that they are not finding the classes (uninitialized constant Iev::DbWriter)

I do not have the time to fix gems I do not maintain. I would prefer to take standoc back to invoking IEV::Db instead of Iev::Db, as the practical thing to do in such a circumstance, but @ronaldtse has vetoed that.

Therefore you need to change all the instances of IEV in this gem back to Iev, release the gem, and take care of any downstream implications in the code you maintain. This is now blocking Metanorma release.

cc @ReesePlews, since you wanted to know the release schedule.

@opoudjis opoudjis added the bug Something isn't working label Jan 6, 2025
@ronaldtse
Copy link
Member

This is one reason why all pending PRs should be merged into the main branch, not on the release date. We will get this fixed ASAP.

@opoudjis
Copy link
Contributor Author

opoudjis commented Jan 6, 2025

Thank you @HassanAkbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants