Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default environment according to wp_get_environment_type() #57

Merged
merged 2 commits into from
May 24, 2021
Merged

Set default environment according to wp_get_environment_type() #57

merged 2 commits into from
May 24, 2021

Conversation

barryceelen
Copy link
Contributor

No description provided.

@jeffpaul jeffpaul added this to the 1.1.0 milestone May 14, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu May 14, 2021 13:58
dinhtungdu
dinhtungdu approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of intermediate variables but it improves the readability so this is looking good to me.

@jeffpaul jeffpaul merged commit 66462f0 into Mather-Sophi:develop May 24, 2021
@barryceelen barryceelen deleted the feature/prepopulate-default-environment branch May 24, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@barryceelen @dinhtungdu @jeffpaul