Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes from VIP scan #50

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Minor fixes from VIP scan #50

merged 1 commit into from
Apr 23, 2021

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Apr 23, 2021

Description of the Change

Minor fixes from VIP Go's code scan

Alternate Designs

None

Benefits

Code now passes VIP's review

Possible Drawbacks

None

Verification Process

N/A

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dkotter dkotter requested a review from dinhtungdu April 23, 2021 03:10
@jeffpaul jeffpaul added this to the 1.1.0 milestone Apr 23, 2021
@jeffpaul jeffpaul merged commit 262bd0f into develop Apr 23, 2021
@jeffpaul jeffpaul deleted the fix/vip-review branch April 23, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu Awaiting requested review from dinhtungdu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dkotter @jeffpaul