Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/sophi #49

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Rename/sophi #49

merged 4 commits into from
Apr 23, 2021

Conversation

jeffpaul
Copy link
Contributor

Description of the Change

This PR removes "for WordPress" from the plugin displayname and main plugin file name to meet WordPress.org naming requirements. I've purposely left sophi-for-wordpress as the repo name so that when viewed from the main globeandmail org perspective its clear that its the WordPress plugin and not some main Sophi.io repo.

Alternate Designs

n/a

Benefits

Ensures we meet WP.org naming standards to be included in their repo.

Possible Drawbacks

none identified

Verification Process

Manually verified via Atom and GitHub Desktop UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Changed
- Renamed plugin from `Sophi for WordPress` to `Sophi`.

Leaving directory name the same to better understand the repo purpose when viewed from the globeandmail org perspective
@jeffpaul jeffpaul added the documentation Improvements or additions to documentation label Apr 23, 2021
@jeffpaul jeffpaul added this to the 1.1.0 milestone Apr 23, 2021
@jeffpaul jeffpaul requested review from dkotter and dinhtungdu April 23, 2021 01:27
@jeffpaul jeffpaul self-assigned this Apr 23, 2021
@jeffpaul jeffpaul merged commit e2330f0 into develop Apr 23, 2021
@jeffpaul jeffpaul deleted the rename/sophi branch April 23, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants