Fix: support both VIP and normal WP CLI #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
reviewed
Apr 21, 2021
includes/classes/Command.php
Outdated
| $this->stop_the_insanity(); | ||
| if ( class_exists( 'WPCOM_VIP_CLI_Command' ) ) { | ||
| // Free up memory. | ||
| $this->stop_the_insanity(); |
There was a problem hiding this comment.
I wonder if it would be worth adding our own version of this method, so if someone isn't on VIP, they still get the performance benefits this provides? I'm not worried about the start_bulk_operation or end_bulk_operation methods, as those don't do much in our case but having this method could help some with performance when processing large batches of content
dkotter
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43.