Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deploy and asset update actions #44

Merged
merged 3 commits into from
Apr 19, 2021
Merged

add deploy and asset update actions #44

merged 3 commits into from
Apr 19, 2021

Conversation

jeffpaul
Copy link
Contributor

Description of the Change

This PR adds the WP.org deploy and readme/asset update actions to ensure we can automate future releases to the dotorg repo. Note that we'll still need to add the Sophi.io SVN_USERNAME and SVN_PASSWORD secrets to this repo once that WordPress.org account is created.

Alternate Designs

none really, but I suppose we could manually deploy to SVN but why?

Benefits

Speeds up releases to WP.org.

Possible Drawbacks

none identified

Verification Process

none, our next release will validate this deploy works

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- GitHub Actions to deploy releases and update readme/asset changes for WordPress.org

@jeffpaul jeffpaul added this to the 1.1.0 milestone Apr 16, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu April 16, 2021 18:23
@jeffpaul jeffpaul self-assigned this Apr 16, 2021
@jeffpaul
Copy link
Contributor Author

@dinhtungdu will want to review each of these closely, especially the deploy action, to ensure we'd be pushing a correctly built plugin to dotorg.

Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a .distignore file to exclude the development files from the release

dinhtungdu
dinhtungdu previously approved these changes Apr 19, 2021
@jeffpaul jeffpaul merged commit 4bb4f7a into develop Apr 19, 2021
@jeffpaul jeffpaul deleted the add/dotorg-actions branch April 19, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants