Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the override settings #362

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Hide the override settings #362

merged 2 commits into from
Nov 9, 2022

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Nov 9, 2022

Description of the Change

Since we are holding on the override functionality for now, this PR hides the settings for those but leaves all other functionality in place (so we can easily turn this back on when ready).

This PR also fixes an issue I found where we may return an empty string instead of an array of posts and this can throw a warning when we try and iterate over that. Also fixes a few PHPCS issues that were being flagged.

Closes #357

Alternate Designs

Could leave the settings in place and just ignore them

Possible Drawbacks

Since we've left the block functionality in place, not the best UX since those overrides won't work

Verification Process

Verify the override settings no longer show up
Verify that the site automation block still works

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Removed - Comment out the override settings for now.
Fixed - Ensure we have an array of items before iterating over them.

Credits

Props @dkotter

@dkotter dkotter self-assigned this Nov 9, 2022
@dkotter dkotter requested a review from jeffpaul November 9, 2022 18:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul added this to the 1.3.1 milestone Nov 9, 2022
Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 hiding all that override goodness from 1.3.0, oh well this looks good otherwise, thanks!

@jeffpaul jeffpaul merged commit afa04b0 into develop Nov 9, 2022
@jeffpaul jeffpaul deleted the fix/357 branch November 9, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Overrides settings from Sophi Settings page
2 participants