fix/338: add Util function to fetch primary category #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadic
suggested changes
Oct 31, 2022
| $this->assertEquals( $term_name, 'Uncategorized' ); | ||
| } | ||
|
|
||
| public function test_get_primary_category__custom_category__yoast_activated() { |
There was a problem hiding this comment.
Looks like this last test is a full-copy of the previous one (except the category name) and does not test any alternative workflow.
cadic
approved these changes
Nov 1, 2022
|
Holding off on merge here as we're awaiting Sophi team approval on the pending 1.3.0 release and I'd prefer to not change any additional code. Once 1.3.0 is released, I'll merge this in so we can deploy/test and prepare as part of a 1.3.1/1.4.0 release. |
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds a Util function
get_primary_category.This function returns the primary category name set through Yoast.
If Yoast is deactivated, then it returns the category set at index 0.
Closes #338
Verification Process
Checklist:
Changelog Entry
Credits
Props @vjayaseelan90 @jeffpaul @Sidsector9