-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/328 Sophi Overrides API Integration #333
Conversation
Pinging @fabiankaegy for initial code review / feedback on approach here to help guide any iterations or strong recommendations on how best to tweak approach here for an optimal editorial UX. |
} | ||
|
||
// eslint-disable-next-line array-callback-return | ||
data.map((item) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't care about the returned value you can also use .forEach
here. It doesn't care about a return value
@faisal-alvi for the nested block override buttons, please ensure they're labeled |
…posts do not exit in the site
…ordpress into enhancement/328
Kudos, SonarCloud Quality Gate passed!
|
Description of the Change
Closes #328 & Closes #216
Alternate Designs
List view:
image link
The 4 Override buttons:
image link
Add/Replace Override Popup:
image link
Out/Ban Override Popup:
image link
Settings page:
image link
When posts are received from the Sophi server, but none of them exist in the WordPress site:
image link
When posts are received from the Sophi server, but none of them exist in the WordPress site:
image link
Possible Drawbacks
Verification Process
Blockcontrol
) at the top.Checklist:
Changelog Entry
Credits
Props @jeffpaul @fabiankaegy @faisal-alvi